Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error messages for non-existing path #2591

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Fix error messages for non-existing path #2591

merged 2 commits into from
Sep 11, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jul 15, 2024 •
edited
Loading

Fixes #1881

Now:

❯ ctapipe-process --config /does/not/exist
2024-07-15 17:27:04,877 CRITICAL [ctapipe.ctapipe-process] (application.inner): Bad config encountered during initialization: The 'config_files' trait of a ProcessorTool instance contains a Path of a List which expected a pathlib.Path or non-empty str for an existing file, not the PathError '/does/not/exist': does not exist.

Tobychev
Tobychev previously approved these changes Jul 15, 2024
View reviewed changes
Tobychev
Tobychev previously approved these changes Jul 16, 2024
View reviewed changes
@ctao-dpps-sonarqube CTAO-DPPS-SonarQube
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 85.70% Coverage (94.20% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.60% Estimated after merge)

Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs

View in SonarQube

@kosack kosack merged commit 4b85d1f into main Sep 11, 2024
12 checks passed
@maxnoe maxnoe added this to the 0.22.0 milestone Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tobychev Tobychev Tobychev approved these changes

@kosack kosack kosack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.22.0
Development

Successfully merging this pull request may close these issues.

Error message for non-existing config-file is suboptimal
3 participants
@maxnoe @Tobychev @kosack